Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --no-hardlinks option #499

Merged
merged 6 commits into from
Mar 27, 2022
Merged

add --no-hardlinks option #499

merged 6 commits into from
Mar 27, 2022

Conversation

t-mangoe
Copy link
Contributor

Description

Thanks for contributing this Pull Request. Add a brief description of what this Pull Request does. Do tag the relevant issue(s) and PR(s) below. If required, add some screenshot(s) to support your changes.

I added --no-hardlinks option.
This PR closes #440 issue.

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2022

Codecov Report

Merging #499 (a7cb1cc) into main (d4e1f1c) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #499      +/-   ##
==========================================
+ Coverage   89.43%   89.61%   +0.18%     
==========================================
  Files           8        8              
  Lines         568      578      +10     
==========================================
+ Hits          508      518      +10     
  Misses         60       60              
Impacted Files Coverage Δ
lib/colorls/core.rb 90.36% <100.00%> (+0.07%) ⬆️
lib/colorls/flags.rb 88.88% <100.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4e1f1c...a7cb1cc. Read the comment docs.

Copy link
Collaborator

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM. I just added a call to the newly introduced test/checks file, to have this covered there as well.

@avdv avdv merged commit ce46ab1 into athityakumar:main Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: toggle output of link column in long format
3 participants